Repository navigation
Conversation
Inline-size containment zeroes the metrics box's content width; with only a flex-basis the right group sized it to 0 and the topbar-speed container query hid the pill on every screen. Regressed in cace683.
Broglah1
marked this pull request as ready for review
November 15, 2026 15:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generation-speed pill in the top bar never shows. The rate is computed and rendered (
98.0 t/s, tooltipcurrent: 98.0 t/s), but the pill isdisplay: noneat every window width.Cause
.shell-topbar-metricshascontainerType: "inline-size". Inline-size containment makes the box report no content width. The right top-bar group is content-sized, so it reserves only the bell and panel buttons (68px), and the metrics box gets 0px even with aflexbasis. The@container topbar-speed (width < calc(10ch + 33px))rule then hides the pill unconditionally.Regressed in cace683, which replaced the explicit
width: hasGenerationSpeed ? 200 : 0with a flex basis only.Fix
Give the box an explicit
width: calc(10ch + 33px), matching its flex basis and the pill's own width.minWidth: 0and the flex shrink are unchanged.Verification
Built this branch (
bun run build,bun server/main.tson a second port linked to the local daemon) and opened a live streaming session in headless Chromium and WebKit:display: none, value98.0 t/spresent)⚡ 113.4 t/slivedisplay: none(existing mobile rule)Same results in Chromium and WebKit (dark theme); the light theme was checked in Chromium at 1600px. The
~session average also shows between runs (checked on v0.7.1 with the same width applied to the page). The top bar did not overflow at any tested width; the container-query hide was never reached, because the left tools fold into the overflow menu first.bun run typecheckpasses.Summary by CodeRabbit