Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 8eeb840 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(card)!: add `<pf-v6-card>`"
} |
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<pf-v5-card>to<pf-v6-card>and removespf-v5-cardheader,title,subtitle,actions,footer,expandable-content) plus onepf-v6-card-bodysub-elementvariant="secondary",size="compact|large",plain,glass, andfull-heightselectedsubmitsvalue(defaulton) undernameand resets with the formselection="single"groups radios across shadow roots with roving tabindex and Arrow/Home/End<a>(href/target) or a shadow<button>; combinable withselectableexpandedstate;expand,collapse, andchangeevents are cancelableaccessible-label→ title → header heading → header imagealt--pf-v6-c-card--*design tokensCloses #2986
Intentional divergences from React
CardHeader,CardTitle,CardBody, …) replaced by slots andpf-v6-card-bodyis*booleans renamed without the prefix (isSelectable→selectable, …)isCompact/isLargereplaced by one exclusivesizeenumselectableActions.variant→selection="single";isHidden→hide-inputonExpand/onChangecallbacks → cancelableexpand/collapse/changeeventshasNoOffset→ card-levelno-offset;to/isExternalLink→href/targetselectableActionAriaLabelledbyis not supported cross-root; useaccessible-labelcomponent, OUIA props,innerRef, and prop spreading not implemented; slot a heading for document semanticsFollow-up tasks
<button>demo actions with<pf-v6-button>once it ships (PR feat(button)!: port to<pf-v6-button>#3157)<pf-v6-checkbox>/<pf-v6-radio>once they ship (PRs feat(checkbox): add pf-checkbox #2608, feat(radio): add pf-radio #2882);hide-inputmust hide the whole elementTest plan
npm run testpassesnpm run lintandtspc -b elementspasslocalhost:8000with?rendering=chromelesschangeis cancelablehrefand ignore clicks on nested interactive contentexpand/collapseare cancelableprefers-reduced-motiondisables the transitioncem healthscore above 80%