Repository navigation
ci: check that hack/core.sh is release-tools' xhandler/core.sh - #7
Closed
carlosthe19916 wants to merge 1 commit into
Closed
carlosthe19916 wants to merge 1 commit into
carlosthe19916 wants to merge 1 commit into
Conversation
The three libraries' hack/core.sh were identical only by convention. release-tools now holds the original (xhandler/core.sh); make verify-core-script compares this copy with it and CI runs it, so a copy that drifts fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Superseded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hack/core.shwas identical in the three libraries only by convention. release-tools now holds the original, inxhandler/core.sh(project-openubl/release-tools#24).make verify-core-script: downloads the original and diffs this copy against it. CI runs it, so a copy that drifts fails with "change it there first, then copy it".hack/core.shgets the original's header, which points to release-tools.Merge release-tools#24 first. Until then, this check fails with a 404, then re-run CI. Tested against #24's branch: identical passes, a modified copy fails with a diff, and a missing original fails with the 404.
🤖 Generated with Claude Code