Skip to content

refactor: download core.sh from xhandler-rust instead of keeping a copy - #8

Merged
carlosthe19916 merged 1 commit into
project-openubl:mainfrom
carlosthe19916:refactor/fetch-core-sh
Nov 15, 2026
Merged

carlosthe19916 merged 1 commit into
project-openubl:mainfrom
carlosthe19916:refactor/fetch-core-sh

Conversation

@carlosthe19916

Copy link
Copy Markdown
Member

hack/core.sh was a copy of the script that syncs and verifies a released core, identical in the three libraries only by convention. It now lives in xhandler-rust as xhandler-wasm/core.sh (project-openubl/xhandler-rust#609), next to the release format it reads, and xhandler-rust tests it in CI.

  • No copy: make sync CORE=, make verify-core and make verify-release download it from the tag of the core at hand, falling back to xhandler-rust's main for an older or unreleased core. It's saved to a temporary file and then run, never piped into bash, so a dropped connection can't run half a script.
  • Local override: CORE_SH=<path> runs a local copy, for example while changing it in xhandler-rust.
  • Deleted: hack/core.sh. CONTRIBUTING.md explains the above.

Merge xhandler-rust#609 first, then re-run this PR's CI. Until then, the script is not on xhandler-rust's main.

Tested against a local server playing GitHub raw and releases: sync and verify-release use the tag's script, an unreleased core falls back to main and only warns, CORE_SH works, and an unreachable script URL fails.

🤖 Generated with Claude Code

hack/core.sh was a copy of the script that syncs and verifies a released
core, identical in the three libraries only by convention. It now lives in
xhandler-rust (xhandler-wasm/core.sh), next to the release format it
reads; make sync CORE=, make verify-core and make verify-release download
it from the tag of the core at hand (from main for an older or unreleased
core) into a temporary file and run it. CORE_SH=<path> runs a local copy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@carlosthe19916
carlosthe19916 merged commit 4679ead into project-openubl:main Nov 15, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant