Repository navigation
feat(xsender): read the CDR's document description - #9
Merged
Merged
Conversation
xhandler 6.0.0-alpha.2 adds `document_description` to the CDR: for an accepted guía de remisión, the URL its printed copy's QR code must encode. The binding reads it, and keeps working with older cores, where it's absent. Interim until the binding generates its answer types from the core's schema (xhandler-rust docs/adrs/BINDINGS.md). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
xhandler 6.0.0-alpha.2 adds
document_descriptionto the CDR. For an accepted guía de remisión, it's the URL its printed copy's QR code must encode. The core always sends it (nullfor other documents).The answer models use
extra="forbid", so every CDR from the alpha.2 core would fail validation. That includes the release's own sync PR.What
CDR,Fault,NoCDR,SendResult,VerifyResult,ConsultStatus,ConsultResult) get an_Answerbase withextra="ignore", so a newer core never breaks them. The inputs stay strict.CDR.document_description: str | None.The binding keeps working with older cores, where the field is absent.
This is interim. After alpha.2, the binding will generate its answer types from the core's schema, so later fields need no hand edit (project-openubl/xhandler-rust#613,
docs/adrs/BINDINGS.md).Verified
document_description.Senior review
Two passes, no findings to fix in this change.
🤖 Generated with Claude Code