[chrikrah]

Enum accepts a states list with a repeated entry and exposes one sample per entry, so the family carries two e{e="a"} samples. After state('a') they disagree, and the OpenMetrics parser keeps only the first.

# base ff9a2d3, python 3.12; repro.py builds Enum('e', 'h', states=['a', 'b', 'a']), calls
# state('a'), prints the OpenMetrics exposition and parses it back
$ python repro.py
# HELP e h
# TYPE e stateset
e{e="a"} 1.0
e{e="b"} 0.0
e{e="a"} 0.0
# EOF
parsed: [({'e': 'a'}, 1.0), ({'e': 'b'}, 0.0)]
$ python repro.py 2>&1 | tail -1   # this branch
ValueError: Duplicate states for Enum metric e: ['a']

That breaks the OpenMetrics StateSet rule, "StateSets MUST have one sample per State", and enum.md, which promises one time series per state. The check sits with the other Enum argument checks, ahead of super().__init__(), so a rejected metric is never registered, as #1189 arranged for empty states.

Verification

$ python -m pytest -q
429 passed, 14 skipped, 28 subtests passed   # this branch
428 passed, 14 skipped, 28 subtests passed   # base ff9a2d3
$ python -m pytest -q   # metrics.py reverted, test kept
1 failed, 428 passed, 14 skipped, 28 subtests passed   # TestEnum::test_duplicate_states
$ flake8 prometheus_client/ tests/   # flake8 7.4.1
$ isort --check prometheus_client/ tests/   # isort 5.10.1
$ mypy prometheus_client tests/test_core.py   # mypy 2.4.0
Found 5 errors in 2 files   # identical at base
# not run: tox on other interpreters, PyPy

There is no issue for this. #1234 rewrites the same lines of Enum.__init__ to accept an enum class, whose member names cannot repeat, so whichever lands second needs a one-line rebase.

@csmarchbanks, this raises for the reason you gave on #1214: a repeated state is almost certainly a typo. A caller who has one today gets a ValueError at construction in place of a contradictory sample. Happy to land it before or after #1234, whichever you merge first.

[csmarchbanks]

Has a conflict now, but generally 👍. Thanks!

[chrikrah]

@csmarchbanks rebased onto e2f2bf9; the only conflict was my import collections against the import math that master added on the same line. The change itself is unchanged.

$ python -m pytest tests -q          # 6adbad7 on master e2f2bf9, CPython 3.12, tox optional deps installed
454 passed, 32 subtests passed
$ python -m pytest tests/test_core.py -q -k duplicate_states   # metrics.py from e2f2bf9, test kept
1 failed, 122 deselected
$ flake8 prometheus_client/ tests/ && isort --check prometheus_client/ tests/   # flake8 7.5.0, isort 5.10.1

It's ready for a merge whenever you have a slot.