Repository navigation
ps2link: Fix IOP exception-report packet overflow - #67
Merged
Merged
Conversation
Use an explicit, ABI-compatible wire packet struct that reserves the command header and a full 128-byte module name. Keep the EE offsets unchanged, cap and terminate names, and validate packet layout and boundary cases in portable C under CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous exception packet allocates
sizeof(exception_frame_t) + 8 + 128bytes, but writes an extra four-byte packet header before the frame. A 124-127-character IOP module name can therefore overrun the static buffer by up to four bytes during exception handling.Fix
Validation
make -j4 LOADHIGH=0).git diff --check: passed.