Repository navigation
build: move the shared Justfile recipes into modules, with the docs diagram work - #74
Merged
Merged
Conversation
kieronlanning
enabled auto-merge (squash)
November 16, 2026 08:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Two pieces of work that were sitting uncommitted in the working tree, rebased onto
mainas it stands (#72catalogue record,#73skills layout):build:the rootJustfileno longer carries the shared recipes. It holds this repository's variables and one import;build,test,pack,restore,lint-check/lint-fix,vs,scrub,version,bump, the pipeline runs and theskills-*targets are modules under.build/just/, copied verbatim from thepurview-buildsdk-justfileskill.test_filtermatchesBuild.TestFilterin.config/purview-build.json,skills_projectpoints at the core project becauseBenchmarksshadowsDirectory.Build.props, andpipeline-local-releasekeeps the repository's existing format-before-release step.docs:the last ASCII-art diagram - the Blazor project map - becomes apurview:likec4block: a LikeC4 model underdocs/wiki/diagrams/paired with the Mermaid GitHub renders, so purview.dev draws it interactively and GitHub still shows a diagram. Every unlabelled fence in the wiki and README gains its language,Contributing.mddocuments the two conventions and the newdiagrams/folder, and theDocumentationWikiTestssentence is corrected now thatdiagrams/holds non-pages.Factoring in the other work
The working tree also carried an earlier, superseded draft of the skills-layout prose -
.agents/skills/rewritten toskills/in the install instructions, including "Pass-a universal, which writesskills/", which would install into the published folder.#73already landed that change correctly, so those hunks are dropped: every edit toAGENTS.mdandContributing.mdhere is re-applied on top of#73's text, and.github/copilot-instructions.mdis left exactly as#73wrote it.Restoring the install also surfaced a real defect in another repository:
skills/add-project-intake/SKILL.mdin purview-dev/purview-dev.github.io wrote its description as a plain YAML scalar containing:, so the skills CLI skips it and fails the whole source -skills add purview-dev/purview-dev.github.iocould not install any of that repository's eleven skills. Fixed in purview-dev/purview-dev.github.io#71.Verification
dotnet test --project src/tests/Repository.UnitTests/Repository.UnitTests.csproj -c Debug- 46/47, the one failure beingLockfile_GivenEveryEntry_HasItsSkillInstalledUnderAgents, which fails only because this clone's.agents/skills/install is mid-restore (see below); it passes on a fresh clone, where there is no local install.just lint-check- 711 files, clean.just --listplus a dry-run over the recipes, includingskills-check.bunx likec4 validate docs/wiki/diagrams- valid.Skills lockfile
skills-lock.jsonis refreshed in its ownchore:commit: the four sources are re-added against their current content - this includes the eleven skillspurview-dev/purview-dev.github.iopublishes fromskills/, which could not be installed at all before #71 - and the stalepurview-buildsdk-skills-justfileentry, a leftover of that skill's rename upstream with no installed folder anywhere, is dropped. The lockfile and the local install now agree exactly (39 entries, 39 folders), so both directions ofInstalledSkillTestspass.