Repository navigation
feat(scenegraph): query single nodes and app-ui instead of the full dump - #131
Merged
Merged
Conversation
On Roku OS 11 (Streaming Stick 3500X), /query/sgnodes/all can freeze the device into a watchdog reboot when it runs while the app builds a screen. Polling it during a Select that opens a new screen rebooted the stick on the first round in 3 of 3 runs; /query/sgnodes/nodes?node-id= and /query/app-ui survived 30 rounds each. Node waits (wait-node, wait-ready --node, press --until) only read the target node's own attributes, so they now use the single-node query. querySceneGraph and waitForSceneGraphAssertion take source: "app-ui" for callers that need a tree; sgnodes stays the default.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
putio-ci Bot
added a commit
that referenced
this pull request
Nov 17, 2026
## [2.5.0](v2.4.7...v2.5.0) (2026-11-17) ### Features * **scenegraph:** query single nodes and app-ui instead of the full dump ([#131](#131)) ([b19beda](b19beda))
Contributor
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node waits no longer dump the whole scene graph, and full-tree reads can use
app-ui, which keeps an old Roku from rebooting mid-test./query/sgnodes/all/query/sgnodes/nodes?node-id=…/query/app-uiRisks
app-uidrops hidden screens and non-visual nodes, sosgnodesstays the default.Verification
wait-nodeagainst the stick:visibleandabsentmatch,hiddenon a visible node fails.Follow-Ups
putio-roku's harness moves its reads to
app-ui.