Skip to content

feat(scenegraph): query single nodes and app-ui instead of the full dump - #131

Merged
altaywtf merged 1 commit into
mainfrom
fix/scenegraph-node-query
Nov 17, 2026
Merged

altaywtf merged 1 commit into
mainfrom
fix/scenegraph-node-query

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Summary

Node waits no longer dump the whole scene graph, and full-tree reads can use app-ui, which keeps an old Roku from rebooting mid-test.

Polled during Select → new screen → Back, Roku Stick 3500X, OS 11 Reboots
/query/sgnodes/all round 1, in 3 of 3 runs
/query/sgnodes/nodes?node-id=… 0 in 30 rounds
/query/app-ui 0 in 30 rounds
await waitForSceneGraphAssertion(context, "files open", assertFiles, { source: "app-ui" });

Risks

  • app-ui drops hidden screens and non-visual nodes, so sgnodes stays the default.

Verification

wait-node against the stick: visible and absent match, hidden on a visible node fails.

Follow-Ups

putio-roku's harness moves its reads to app-ui.

On Roku OS 11 (Streaming Stick 3500X), /query/sgnodes/all can freeze the
device into a watchdog reboot when it runs while the app builds a screen.
Polling it during a Select that opens a new screen rebooted the stick on the
first round in 3 of 3 runs; /query/sgnodes/nodes?node-id= and /query/app-ui
survived 30 rounds each.

Node waits (wait-node, wait-ready --node, press --until) only read the
target node's own attributes, so they now use the single-node query.
querySceneGraph and waitForSceneGraphAssertion take source: "app-ui" for
callers that need a tree; sgnodes stays the default.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T08:59:43.213660Z 0b764b3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf
altaywtf merged commit b19beda into main Nov 17, 2026
2 checks passed
@altaywtf
altaywtf deleted the fix/scenegraph-node-query branch November 17, 2026 09:01
putio-ci Bot added a commit that referenced this pull request Nov 17, 2026
## [2.5.0](v2.4.7...v2.5.0) (2026-11-17)

### Features

* **scenegraph:** query single nodes and app-ui instead of the full dump ([#131](#131)) ([b19beda](b19beda))
@putio-ci

putio-ci Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant