Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 27 27
Lines 4983 4983
=======================================
Hits 4668 4668
Misses 315 315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tomasr8
commented
Nov 10, 2026
hugovk
reviewed
Nov 12, 2026
Member
Author
|
This is not the first time the CI fails for PyPy on Windows (another run: https://github.com/python-babel/babel/actions/runs/43040240030/job/130589759461) though it fails in different steps and the error is not very helpful either.. It seems like it started happening after the Windows runner update to 2025 so it's probably related. |
Member
Author
|
Hmm maybe it's not because of the runner update. There seems to some issue w/ PyPy on Windows and the latest version of pip: pypa/pip#14431 |
Member
Author
|
Opened #1462 to try to fix it |
Some doctests, like `core.default_locale` modify os.environ, including setting a different locale, without proper cleanup. When a PyPy subprocess spawned by `test_setuptools_commands` tries to set the non-existent locale, it crashes which makes the test fail. This PR adds a cleanup fixture that restores os.environ after every test.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 7.3.19 in February 2025 was the last release to include PyPy 3.10. Following releases dropped it in favour of PyPy 3.11. Let's use that one.
This PR also fixes one xfail test on PyPy.