Repository navigation
Conversation
tomasr8
commented
Nov 12, 2026
| else: | ||
| pattern = locale.zone_formats['gmt_utc' if utc else 'gmt'] % '%s%02d:%02d' | ||
| return pattern % (sign, hours, seconds // 60) | ||
| # The long format shows seconds if the zone offset has any |
Member
Author
There was a problem hiding this comment.
The short localized format does that too, but we don't support it (we only support ISO short). I'd like to add it in a follow up.
tomasr8
force-pushed
the
zone-offset-seconds
branch
from
November 12, 2026 21:10
138e20d to
856787e
Compare
tomasr8
force-pushed
the
zone-offset-seconds
branch
from
November 14, 2026 18:50
856787e to
ae7afad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
=======================================
Coverage 93.67% 93.68%
=======================================
Files 27 27
Lines 4983 4987 +4
=======================================
+ Hits 4668 4672 +4
Misses 315 315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while working on the skeleton matching.
Per the spec, the localized GMT format includes seconds when applicable, which we currently ignore:
There are real (albeit historic) timezones with sub-minute offsets, e.g.
Africa/Monroviabefore 1972:I suggest we make
get_timezone_gmtdisplay seconds when applicable