Repository navigation
Conversation
tomasr8
force-pushed
the
tox
branch
2 times, most recently
from
November 13, 2026 20:58
0fbf3e1 to
3663f96
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
+ Coverage 93.67% 93.83% +0.16%
==========================================
Files 27 27
Lines 4983 4983
==========================================
+ Hits 4668 4676 +8
+ Misses 315 307 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tomasr8
marked this pull request as ready for review
November 14, 2026 19:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally just wanted to remove the
py38env from tox but then (as it usually happens 😆 ) I noticed thepytz,jinjaandsetuptoolsenvs. They all install the samedevextra meaning we run the same test suite multiple times, one for each env.The envs actually used to install the respective packages (
pytz,jinjaandsetuptools) until #1159 which removed it. I don't think we need to fully restore this behaviour, probably one env with the optional dependencies and one without is enough, which is what I've done here.I also took the liberty to switch to dependency groups since there was the
TODOinpyproject.tomland it just felt natural here. There are now two groups:test: installs only what is needed for the testsdev: installs the extras (pytz, etc..)Tox runs the
devgroup on all versions + runs the baretestgroup on py314 only.Feedback welcome! :)