Repository navigation
Clear base fragments when clicking empty references - #209
Open
theman6660 wants to merge 1 commit into
Open
theman6660 wants to merge 1 commit into
theman6660 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the base URL has a fragment,
click("")andclick()retain it, whileclick(URL())clears it. For example,URL.from_text("http://example.com/a/b?x=1#old").click("")returns the URL with#oldstill attached.Clear the base fragment in the empty-text/default-argument branch, retaining the existing path/query and dot-segment handling. This agrees with the structured empty-reference behavior and RFC 3986 section 5.2.2, where the target fragment comes from the reference. Node's URL resolution also drops the old fragment for an empty reference.
Regression tests cover URL and DecodedURL, default/empty-text/structured empty references, base queries, dot segments, explicit fragment replacement/clearing, and base immutability. This is independent of #208 and is based directly on upstream master.
Validation on Windows / Python 3.12.10:
git diff --checkpass. Older interpreter matrix not run.Found during source inspection. Implementation, tests, and this description were prepared with OpenAI Codex at my request.