Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ZandZZoffset tokens already acceptZandzin their regular expressions, butfrom_format()then tries to parse them as numeric offsets. For example, parsing1975-05-21T22:32:11ZwithYYYY-MM-DD[T]HH:mm:ssZfails withValueError: invalid literal for int() with base 10: ''.Normalize the accepted UTC designators to
+00:00before the existing offset conversion. Tests cover both token forms, both designator cases, numeric-zero controls, and an explicit non-UTC default timezone.Validation on Windows / CPython 3.12 using the pure-Python source: 8 failures and 8 passing controls before the change; all 16 pass afterward. The full suite has 1,883 passes, 5 skips and the existing timezone-name failure in
test_instance_with_aware_datetime_any_tzinfo. Mypy on the changed source and all applicable pinned prek hooks pass; the Rust hook has no matching changed files. The Rust extension was not built locally.This contribution was prepared with Codex assistance.