Skip to content

On Windows, resource paths are now always interpreted to be relative to project directory - #950

Open
lieryan wants to merge 22 commits into
lieryan-subprefsfrom
lieryan-projectpy-test-refactoring
Open

lieryan wants to merge 22 commits into
lieryan-subprefsfrom
lieryan-projectpy-test-refactoring

Conversation

@lieryan

@lieryan lieryan commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Description

  • Organise projecttest.py tests into logical chunks
  • Minor code modernisation
  • Change project fixture setup to disable creation of .ropefolder by default
  • Make how get_resources() handle absolute resource paths more consistently between Linux and Windows. resource paths are not filesystem paths, they are supposed to always be forward-slash-separated path relative to the project directory, even on Windows. They weren't supposed to be absolute path to begin with, but previously these paths were not rejected and hadn't been handled consistently between Linux and Windows. Now resource paths are always interpreted to be relative to project directory, even if they start with a path separator, matching the behavior in Linux.

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.81395% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.48%. Comparing base (785ac61) to head (d10c0f9).

Files with missing lines Patch % Lines
ropetest/projecttest.py 95.67% 18 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           lieryan-subprefs     #950      +/-   ##
====================================================
+ Coverage             95.46%   95.48%   +0.01%     
====================================================
  Files                   135      135              
  Lines                 26982    27110     +128     
====================================================
+ Hits                  25759    25886     +127     
- Misses                 1223     1224       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lieryan
lieryan force-pushed the lieryan-projectpy-test-refactoring branch 3 times, most recently from 6717666 to 652c9a9 Compare November 11, 2026 00:30
@lieryan
lieryan enabled stacked auto-merge November 11, 2026 00:31
@lieryan
lieryan force-pushed the lieryan-projectpy-test-refactoring branch 3 times, most recently from d19ac8e to 7c53387 Compare November 13, 2026 15:52
@lieryan
lieryan disabled stacked auto-merge November 13, 2026 17:21
@lieryan
lieryan added this pull request to stack #952 November 13, 2026 17:22
lieryan added a commit that referenced this pull request Nov 13, 2026
Updated entry for issue #950 to clarify changes regarding resource path interpretation on Windows.
@lieryan lieryan changed the title Reorganise projecttest.py and improve test coverages On Windows, resource paths are now always interpreted to be relative to project directory, even if they start with a drive name or a path separator, matching the behavior in POSIX/Linux/MacOS Nov 13, 2026
@lieryan lieryan changed the title On Windows, resource paths are now always interpreted to be relative to project directory, even if they start with a drive name or a path separator, matching the behavior in POSIX/Linux/MacOS On Windows, resource paths are now always interpreted to be relative to project directory Nov 13, 2026
@lieryan
lieryan force-pushed the lieryan-projectpy-test-refactoring branch 2 times, most recently from 3ebecca to 3fd01ac Compare November 13, 2026 18:56
@lieryan
lieryan removed this pull request from stack #952 November 13, 2026 18:59
@lieryan
lieryan added this pull request to stack #955 November 13, 2026 19:00
@lieryan
lieryan removed this pull request from stack #955 November 13, 2026 19:03
@lieryan
lieryan force-pushed the lieryan-projectpy-test-refactoring branch from 3fd01ac to d10c0f9 Compare November 13, 2026 19:03
@lieryan
lieryan changed the base branch from master to lieryan-subprefs November 13, 2026 19:03
@lieryan
lieryan added this pull request to stack #956 November 13, 2026 19:03

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant