Skip to content

Implement dotted-syntax handling for handling subpreferences with the get()/__getitem__/__setitem__ syntaxes - #951

Open
lieryan wants to merge 3 commits into
masterfrom
lieryan-subprefs
Open

lieryan wants to merge 3 commits into
masterfrom
lieryan-subprefs

Conversation

@lieryan

@lieryan lieryan commented Nov 13, 2026

Copy link
Copy Markdown
Member

Description

The pytoolconfig-based preference system added subpreference, but there was never a clean way to programmatically get/set these subpreference.

This PR implements the dot-syntax to set subpreferences, e.g. project.set("imports.preferred_import_style", "from-module").

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md
  • I have made corresponding changes to library documentation for API changes

@lieryan
lieryan added this pull request to stack #952 November 13, 2026 17:22
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (lieryan-projectpy-projectroot-validation@e3f5e3a). Learn more about missing BASE report.

Additional details and impacted files
@@                             Coverage Diff                             @@
##             lieryan-projectpy-projectroot-validation     #951   +/-   ##
===========================================================================
  Coverage                                            ?   95.39%           
===========================================================================
  Files                                               ?      135           
  Lines                                               ?    27145           
  Branches                                            ?        0           
===========================================================================
  Hits                                                ?    25896           
  Misses                                              ?     1249           
  Partials                                            ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lieryan
lieryan force-pushed the lieryan-subprefs branch 2 times, most recently from 5b54fcc to 705f890 Compare November 13, 2026 18:56
@lieryan
lieryan removed this pull request from stack #952 November 13, 2026 18:59
@lieryan
lieryan changed the base branch from lieryan-projectpy-test-refactoring to lieryan-projectpy-projectroot-validation November 13, 2026 19:00
@lieryan
lieryan added this pull request to stack #955 November 13, 2026 19:00
@lieryan
lieryan removed this pull request from stack #955 November 13, 2026 19:03
@lieryan
lieryan changed the base branch from lieryan-projectpy-projectroot-validation to master November 13, 2026 19:03
@lieryan
lieryan added this pull request to stack #956 November 13, 2026 19:03

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant