Skip to content

Implement projectroot validation - #953

Open
lieryan wants to merge 3 commits into
lieryan-projectpy-test-refactoringfrom
lieryan-projectpy-projectroot-validation
Open

lieryan wants to merge 3 commits into
lieryan-projectpy-test-refactoringfrom
lieryan-projectpy-projectroot-validation

Conversation

@lieryan

@lieryan lieryan commented Nov 13, 2026

Copy link
Copy Markdown
Member

Description

Implement validations of resource paths.

  • resource paths must not contains drive name (error)
  • resource paths must not point to a file that escapes the project root (error)
  • resource paths should not start with path separator (warning)

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md
  • I have made corresponding changes to user documentation for new features
  • I have made corresponding changes to library documentation for API changes

@lieryan
lieryan changed the base branch from master to lieryan-subprefs November 13, 2026 17:33
@lieryan
lieryan added this pull request to stack #952 November 13, 2026 17:33
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.43%. Comparing base (d10c0f9) to head (7031f5d).

Files with missing lines Patch % Lines
rope/base/project.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           lieryan-projectpy-test-refactoring     #953      +/-   ##
======================================================================
- Coverage                               95.48%   95.43%   -0.05%     
======================================================================
  Files                                     135      135              
  Lines                                   27110    27145      +35     
======================================================================
+ Hits                                    25886    25907      +21     
- Misses                                   1224     1238      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lieryan
lieryan force-pushed the lieryan-projectpy-projectroot-validation branch 2 times, most recently from aeb22f0 to ad77882 Compare November 13, 2026 18:56
@lieryan
lieryan removed this pull request from stack #952 November 13, 2026 18:59
@lieryan
lieryan changed the base branch from lieryan-subprefs to master November 13, 2026 19:00
@lieryan
lieryan force-pushed the lieryan-projectpy-projectroot-validation branch from ad77882 to e3f5e3a Compare November 13, 2026 19:00
@lieryan
lieryan changed the base branch from master to lieryan-projectpy-test-refactoring November 13, 2026 19:00
@lieryan
lieryan added this pull request to stack #955 November 13, 2026 19:00
@lieryan
lieryan removed this pull request from stack #955 November 13, 2026 19:03
@lieryan
lieryan force-pushed the lieryan-projectpy-projectroot-validation branch from e3f5e3a to 7031f5d Compare November 13, 2026 19:03
@lieryan
lieryan added this pull request to stack #956 November 13, 2026 19:03

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant