Repository navigation
Invalidate cached returns when function bodies change - #959
Open
yangfan-yf-yf wants to merge 2 commits into
Open
yangfan-yf-yf wants to merge 2 commits into
yangfan-yf-yf wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 95.44% 95.49% +0.04%
==========================================
Files 134 139 +5
Lines 26910 27421 +511
==========================================
+ Hits 25685 26186 +501
- Misses 1225 1235 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a function body changes, Rope can reuse a return type observed for the previous body. For example, when a callback changes from returning its first argument to its second argument, a refreshed or reopened project may still infer the first argument's type.
Change
I associate each recorded return with the function's own body and require a matching version when retrieving exact or fallback returns. Existing parameter and per-name observations remain available. Older persisted records without a body version retain their observations, but their returns are ignored for return inference until fresh information is available.
For dynamic analysis, a return is associated with a body only when the running frame matches the current source snapshot. This avoids attributing an old frame's return to a newly written body. If source matching reaches the recursion limit in either the analyzed program or the analysis process, the return remains unverified. An unverified observation cannot replace an existing verified return for the same arguments. The version tracks the function's own body; it does not track parameter signature changes, arbitrary global values, or transitive dependencies. For example, reordering parameters while leaving
return xunchanged can still leave an older inferred return in place; that existing case is outside this change.Validation
Checklist