Repository navigation
Preserve relative imports and aliases when moving globals - #960
Open
marlon-costa-dc wants to merge 1 commit into
Open
marlon-costa-dc wants to merge 1 commit into
marlon-costa-dc wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #960 +/- ##
=======================================
Coverage 95.44% 95.45%
=======================================
Files 134 134
Lines 26910 26968 +58
=======================================
+ Hits 25685 25743 +58
Misses 1225 1225 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving a global can leave consumers importing it from the old module. For example, moving
Thingout ofpkg.origin.__init__leavesfrom .origin import Thing as Aliaspointing at the old package, and importing the rewritten consumer raisesImportError.Resolve relative imports from the consumer’s folder and move the matching alias to the destination. Other names in the same import stay in place. Consumers that use only the alias are also updated.
Verified with the real
create_moveAPI and a subprocess that imports the rewritten consumer: it raisesImportErroronmasterand both references resolve to the destination class after this change. The full Python 3.14 suite passed (2,184 passed, 7 skipped, 5 xfailed).