Repository navigation
Conversation
vmphase
force-pushed
the
fix-sqrtprod-subnormal
branch
from
November 3, 2026 18:21
4dd5461 to
9c77139
Compare
vmphase
requested review from
AA-Turner,
StanFromIreland,
hugovk and
willingc
as code owners
November 3, 2026 18:21
vmphase
force-pushed
the
fix-sqrtprod-subnormal
branch
2 times, most recently
from
November 3, 2026 18:26
a044cda to
955ced3
Compare
vmphase
force-pushed
the
fix-sqrtprod-subnormal
branch
from
November 3, 2026 18:33
955ced3 to
185c365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, passing inputs with tiny sums of squared deviations to
statistics.correlation()returned inaccurate results becausestatistics._sqrtprod()underflowed to subnormal products.Rescale non-zero inputs in
statistics._sqrtprod()when the product underflows or becomes subnormal.