Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…kx-merge-from-python-type-stubs
Avasam
commented
May 14, 2025
Avasam
commented
May 14, 2025
This comment has been minimized.
This comment has been minimized.
This was referenced May 15, 2025
…kx-merge-from-python-type-stubs
This comment has been minimized.
This comment has been minimized.
…kx-merge-from-python-type-stubs
This comment has been minimized.
This comment has been minimized.
…kx-merge-from-python-type-stubs
This comment has been minimized.
This comment has been minimized.
…kx-merge-from-python-type-stubs
This comment has been minimized.
This comment has been minimized.
Avasam
commented
Aug 20, 2025
…kx-merge-from-python-type-stubs
Avasam
commented
Aug 20, 2025
This comment has been minimized.
This comment has been minimized.
…kx-merge-from-python-type-stubs
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 26, 2025
…kx-merge-from-python-type-stubs
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…kx-merge-from-python-type-stubs
This comment has been minimized.
This comment has been minimized.
…kx-merge-from-python-type-stubs
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the stubs from https://github.com/microsoft/python-type-stubs/tree/main/stubs/networkx so that removing them from there produce no regression for Pylance users.
I didn't make much effort in completing annotations other than validating what I was copying over.
In doing that I did find quite a handful of incorrect annotations though.
I've already started a few PRs, and will create more that have specific scopes to make it easier to review these changes in chunks. (and will serve as self-review for this big PR). Until then, I'll keep this as draft.