Repository navigation
Bump setuptools to 84.2.* - #16692
Merged
Merged
Conversation
Avasam
commented
Nov 3, 2026
| def get_flag(var: str, fallback: bool, expected: bool = True, warn: bool = True) -> bool: ... | ||
| def get_abi_tag() -> str | None: ... | ||
| def safer_version(version: str) -> str: ... | ||
| def stable_abi_tag(impl_name: str, impl_version: str) -> Literal["abi3", "abi3.abi3t"] | None: ... |
Collaborator
Author
There was a problem hiding this comment.
Subjectively decided to make return type literal here. Given the few choices from standard.
Could instead do:
Suggested change
| def stable_abi_tag(impl_name: str, impl_version: str) -> Literal["abi3", "abi3.abi3t"] | None: ... | |
| def stable_abi_tag(impl_name: str, impl_version: str) -> str | None: ... |
Also impl_version is intended to receive "315", although it could work with ("3", "15"). But I've never seen tuple version use anything else than actual int, so seems pretty unintended.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16572