You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Typescript support for defining component Interface through React interface #387
I'm playing around with the playground and noticed that if you type your component in this way const MyComponent: React.FC<IProps> = .., react-docgen doesn't pick up the interface in IProps.
I'm curious to know if there's a specific reason for this, and if support for this might be on the roadmap.
Thanks!
Reacted by Josias, Tobias Pickel, nxnze, Cameron Zaas, Ivan Prignano, Scott Hutcheson, Rainke, Aura Munoz, Rodger Jordas, Jason Hong and 146 more
Any guidance on this please? I'd be happy to take a look and create an MR for this if pointed in the right direction / is it something on your roadmap.
Fix for this is up in #1208 — props defined only via React.FC<Props> (interface, type alias, or inline literal) are now resolved, including Flow-parsed sources, React.memo<Props>(...) generics, and named functions assigned to an annotated variable (const C: React.FC<Props> = Inner).
Activity
nxnzesrc commentedon Sep 16, 2019
Any guidance on this please? I'd be happy to take a look and create an MR for this if pointed in the right direction / is it something on your roadmap.
7rulnik commentedon Sep 16, 2019
@johnnycopperstone I think the problem somewhere in this module https://github.com/reactjs/react-docgen/blob/e05219b08c8b17899be812a521b4985f2b66fae2/src/utils/isStatelessComponent.js
You can debug it with
--inspect-brkflag https://nodejs.org/de/docs/guides/debugging-getting-started/danez commentedon Dec 11, 2019
The playground parses the code with flow enabled, but not sure if it would work if it gets parsed as typescript.
josias-r commentedon Jan 14, 2020
The
React.FC<Props>is working for me in the latest version 🤔danez commentedon Jan 18, 2020
I just checked again and the problem is only happening when the Props are only defined in the
React.FC<Props>and not in the props argument itself.Will look into this soon.
Dashue commentedon Mar 11, 2020
Coming here from storybook migration guide to 6.0.
https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-53x-to-60x
This is how we define our components so will wait on this to be resolved, rather than re-writing all our components.
Unfortunately I'm not able to help with a fix for the issue.
Thanks in advance to whoever does :)
Winner95 commentedon Mar 23, 2020
I hope it might help as temporary workaround - I made a custom handler for parsing React.FC < Props >, which points at existing Props at UI-component.
smeevil commentedon May 30, 2020
Keeping my eye on this @danez , 6.0 is looking great so far :)
DeviousCardi commentedon Nov 21, 2026
Fix for this is up in #1208 — props defined only via
React.FC<Props>(interface, type alias, or inline literal) are now resolved, including Flow-parsed sources,React.memo<Props>(...)generics, and named functions assigned to an annotated variable (const C: React.FC<Props> = Inner).