Repository navigation
fix(snack): use @rnmapbox/maps 10.3.18 and pin mapbox-gl and moment - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snackager now rejects packages with non-semver specs in any dependency section (expo/snack#713), so the Edit in Snack links failed on the git
react-docgendevDependency of 10.3.16 and on thenpm:alias devDependencies of currentmapbox-glandmoment(Earthquakes). This moves the Snacks to 10.3.18, which ships without devDependencies, and pinsmapbox-gl@3.26.0andmoment@2.24.0, the newest releases that pass the check. I checked every dependency of the 49 Snack examples against Snackager's version check and ran ShowMap, GradientLine and Earthquakes in headless Chromium: all three render the map with no errors from our packages, while the current links fail with a 422 from Snackager.