Skip to content

fix: preserve source indices for unreadable input maps - #14

Merged
intellild merged 1 commit into
masterfrom
codex/fix-custom-sourcemap-fallback
Nov 2, 2026
Merged

intellild merged 1 commit into
masterfrom
codex/fix-custom-sourcemap-fallback

Conversation

@intellild

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 06:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T06:52:02.724306Z ef91ea2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the CSS source-map fallback change.

No open issues 🎉

What changed in this PR

Preserves CSS source indices in bundled source maps when an input source map cannot be read, allowing the printer to use the original CSS as a fallback.

Changes:

  • Registers the CSS source based on whether the input map can be read, rather than its URL prefix.
  • Adds regression coverage for an external map URL and an invalid inline map, verifying fallback mappings, source paths, and source content.
File Description
tests/​test_bundler_source_map.rs Tests fallback source registration for unreadable input maps.
src/​bundler.rs Checks input-map readability before omitting the CSS source.

Review effort: Balanced

@codspeed

codspeed Bot commented Nov 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing codex/fix-custom-sourcemap-fallback (ef91ea2) with master (bf9722f)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@intellild
intellild merged commit b722247 into master Nov 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants