Repository navigation
fix: preserve source indices for unreadable input maps - #14
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the CSS source-map fallback change.
No open issues 🎉
What changed in this PR
Preserves CSS source indices in bundled source maps when an input source map cannot be read, allowing the printer to use the original CSS as a fallback.
Changes:
- Registers the CSS source based on whether the input map can be read, rather than its URL prefix.
- Adds regression coverage for an external map URL and an invalid inline map, verifying fallback mappings, source paths, and source content.
| File | Description |
|---|---|
tests/test_bundler_source_map.rs |
Tests fallback source registration for unreadable input maps. |
src/bundler.rs |
Checks input-map readability before omitting the CSS source. |
Review effort: Balanced
Merging this PR will not alter performance
Comparing Footnotes
|
No description provided.