Skip to content

refactor: introduce the custom_sourcemap feature flag - #20

Open
intellild wants to merge 1 commit into
codex/rstack-to-css-printer-traitfrom
codex/rstack-rename-sourcemap-feature
Open

intellild wants to merge 1 commit into
codex/rstack-to-css-printer-traitfrom
codex/rstack-rename-sourcemap-feature

Conversation

@intellild

@intellild intellild commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add the custom_sourcemap feature and use it to gate the existing source-map code.
  • Keep sourcemap as a compatibility alias. Both feature names use the existing Parcel implementation at this stage.

Example

A consumer that disables default features can select the new name with features = ["custom_sourcemap"]. Existing code that passes a Parcel map in PrinterOptions::source_map continues to work.

Validation

  • cargo test --locked -p rspack-lightningcss --all-features (184 passed)
  • cargo check --locked -p rspack-lightningcss --no-default-features --features custom_sourcemap
  • cargo check --locked -p rspack-lightningcss --no-default-features --features sourcemap

Stack

  1. Fix bundled source-map indices
  2. Use std::fmt::Write for printer output
  3. Serialize CSS through PrinterTrait
  4. This PR
  5. Custom source maps through generic PrinterOptions

by OpenAI Codex

Copilot AI balanced review requested due to automatic review settings November 4, 2026 09:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T09:01:40.477263Z 44992a0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codspeed

codspeed Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 8 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing codex/rstack-rename-sourcemap-feature (43b17bc) with codex/rstack-to-css-printer-trait (62d0547)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@intellild
intellild removed this pull request from stack #21 November 4, 2026 09:34
@intellild
intellild force-pushed the codex/rstack-rename-sourcemap-feature branch from 44992a0 to 43b17bc Compare November 4, 2026 09:35
@intellild
intellild added this pull request to stack #24 November 5, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants