Repository navigation
test(vscode): port remaining upstream lint extension test gaps - #125
Merged
Merged
Conversation
Close the gaps found by auditing rslint@4933a976e's deleted packages/vscode-extension tests against this repo: - rslint-lifecycle: restore the dropped assertions that a hung initialize tail settles as a rejection and leaves no unhandled rejection behind. - core-resolver: port "rejects an unsupported configured corePath" with a version below the current SUPPORT_MATRIX floor. - worker core: pin loadCoreInstallation's missing / non-file binary rejections in a new unit test.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited every case in rslint@
4933a976e(the last commit before the standalone extension and its tests were deleted) againstpackages/vscode: 178 cases, 156 already ported, 15 obsolete (migration notices,runtimeReady/unsupportedCoreevents, server-restart reset — features removed here). This PR closes the remaining gaps:e2e/lint/suite-jsconfig/ rslint-lifecycle.test.ts settles a hung initialize tail after forced transport close + assert.rejects(startPromise) # restored from upstream + no unhandledRejection within 1.1 s # restored from upstream core-resolver.test.ts + rejects an unsupported configured corePath # ported; 0.7.3 < current floor >=0.8.0 tests/stacks/lint/ + workerCore.test.ts # new: pins worker/core.ts binary guard + rejects a core package whose binary is missing + rejects a core package whose binary is not a fileThe binary check moved from upstream's
CoreResolverinto the Lint worker (src/stacks/lint/worker/core.ts), which the E2E resolver suite cannot reach, so it is pinned as a unit test with a stub Rslint core exposing only the exportsloadCoreInstallationconsumes.Not ported: upstream's version matrix (
0.10.0,0.10.0-canary.1,0.8.2) — its versions are stale against the current floor, and the gate is covered bytests/versionCheck.test.tsandtests/stacks/lint/coreResolver.test.ts.Evidence
startPromisesettling, so a start that resolved or leaked an unhandled rejection still passed; no test exercised thecorePathversion gate or the missing-binary guard.After:
src/— no source change was needed.Merge Danger
Door: two-way
Test-only change; revert is a single commit.
Blast Radius: tests
Adds ~1.1 s to the
JS config testsE2E suite.