Skip to content

fix(release): remove dead ctcOpen/ctcClose args from npmPublish.yml - #206

Merged
iowillhoit merged 1 commit into
mainfrom
fix/npmpublish-ctc-args
Nov 5, 2026
Merged

iowillhoit merged 1 commit into
mainfrom
fix/npmpublish-ctc-args

Conversation

@madhur310

Copy link
Copy Markdown
Contributor

What issues does this PR fix or reference?

Fixes the regression from #205 that broke every npm publish going through npmPublish.yml (e.g. oclif/plugin-plugins run).

Summary

  • fix(ctc): drop unused pnpm cache config from ctcOpen/ctcClose - W-24787945 #205 dropped package-manager, package-manager-version, and cache-dependency-path from ctcOpen.yml/ctcClose.yml's declared inputs, since those workflows never installed the caller's dependencies with them — the only install is a global npm install -g @salesforce/change-case-management. The inputs only ever selected a setup-node cache key, and because nothing populated that cache, the cache-save step failed on every pnpm run.
  • npmPublish.yml's three call sites into ctcOpen.yml/ctcClose.yml (ctc-open, ctcCloseSuccess, ctcCloseFail) still forwarded those now-undeclared inputs. GitHub Actions rejects a reusable workflow call that passes an input the callee doesn't declare, so every release through npmPublish.yml failed at the ctc-open/close step.
  • Removed the three dead with: args from all three call sites. npm-publish's own checkout/cache/install steps (which do use packageManager/packageManagerVersion/cacheDependencyPath for real) are untouched.

Test plan

  • actionlint on the changed file — zero new findings vs main (same pre-existing shellcheck finding, unrelated)
  • Confirmed via GitHub code search that no other caller of npmPublish.yml is affected by this change (the removed args were only ever forwarded to ctcOpen.yml/ctcClose.yml)
  • Confirm a release through npmPublish.yml with ctc: true succeeds once merged

PR #205 dropped package-manager, package-manager-version, and
cache-dependency-path from ctcOpen.yml/ctcClose.yml's inputs. Those
workflows never installed the caller's dependencies with them (only a
global npm install -g @salesforce/change-case-management); the inputs
only selected a setup-node cache key, and since nothing ever populated
that cache, pnpm callers' cache-save step failed every run.

npmPublish.yml's three call sites (ctc-open, ctcCloseSuccess,
ctcCloseFail) still forwarded the now-undeclared inputs, so GitHub
Actions rejected the call outright and broke every release through
npmPublish.yml (e.g. oclif/plugin-plugins).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@madhur310
madhur310 requested a review from a team as a code owner November 5, 2026 19:39
@iowillhoit
iowillhoit merged commit 98e42a8 into main Nov 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants