Skip to content

test(crash): wait for the watcher instead of a fixed sleep - #48

Merged
sanlega merged 1 commit into
mainfrom
fix/47-flaky-abandoned-write-test
Nov 13, 2026
Merged

sanlega merged 1 commit into
mainfrom
fix/47-flaky-abandoned-write-test

Conversation

@sanlega

@sanlega sanlega commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Closes #47

test_write_abandoned_during_restore_is_not_executed slept 1.5 s after docker kill. When keepstack's watcher had not noticed the dead container yet, the probe write hit the dead emulator, failed at once and the test reported restore finished too fast to test (seen on #42 and #46). It now waits for "the emulator stopped" in the log first.

  • Test only, no behaviour change.
  • Passed 3/3 runs in isolation; scripts/verify.ps1: 142 tests OK.

🤖 Generated with Claude Code

@sanlega sanlega added the type: bug Something is broken label Nov 13, 2026
@github-actions

Copy link
Copy Markdown

keepstack validate: examples/quickstart ✅ passed

Step Result
init ✅ ok
plan ✅ ok
apply ✅ ok
idempotency ✅ ok
smoke ✅ ok

Plan: 0 to add, 0 to change, 0 to replace, 0 to destroy

keepstack · 18.2 s · AWS Emulator, no AWS account used

@sanlega
sanlega merged commit b9fd89f into main Nov 13, 2026
12 checks passed
@sanlega
sanlega deleted the fix/47-flaky-abandoned-write-test branch November 13, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_write_abandoned_during_restore_is_not_executed is flaky in CI

1 participant