Repository navigation
feat(computers): a computer that follows the clock follows it again once a multi env's reset replaces its container - #648
Closed
williamloo-scale wants to merge 1 commit into
Conversation
…nce a multi env's reset replaces its container A reset boots the computer afresh, and its clock follower went with the old container, so it showed real time until the next arm. While the gateway's clock is armed, the multi env's reset now starts each such computer's follower again as an arm does, as root, and waits until the computer shows the clock; a clock not armed is left to the next sync_env_clock. The follower start is shared with sync_env_clock, and the end-to-end test resets the env and checks the new container agrees with the gateway. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing: superseded by #649, which puts ubuntu-24.04 computers on the gateway's clock from the base image, with core configuring the follower at deploy and after a reset. FD-5477's remaining arm-time work ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A multi env's reset boots a computer afresh, and its clock follower went with the old container, so the computer showed real time until the next
sync_env_clock. Now, while the gateway's clock is armed, the reset starts each such computer's follower again, the same way an arm does and as root. It then waits until the computer shows the clock, reading the follower's status as root. If the clock isn't armed, the follower is left to the next arm.The follower start is shared between
sync_env_clockand the reset (_multi_computers.start_clock_follower), andFOLLOWER_WAIT_Smoves tocomputer/utils/clock.py.How it was tested
follow_clock_againwith the clock armed and not armed, andclock.wait_shown.Notes
Stack: follower → sync → e2e → this.
🤖 Generated with Claude Code