Repository navigation
feat(computers): routed sites' certificates hold at any date a computer's clock can show (FD-5480) - #654
Merged
earakely-scale merged 2 commits intoNov 13, 2026
Conversation
…er's clock can show (FD-5480) The deploy's CA and each routed site's certificate are valid from 1971 to 2099, not the deploy's ttl from real now, so a program on a computer whose clock is armed in the past or the future, which checks a certificate against the universe's time, still takes them. The CA is name-constrained and its key discarded once they're signed, so the wider window vouches for nothing more. The ttl the window took is no longer passed to the site routing or kept in the deploy record. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ertificate carries, 1950 to 9999 The gateway's clock takes dates past 2099, which the 1971 to 2099 window left out. The CA and site certificates now run from 1950, the earliest a certificate holds, to 9999-12-31 23:59:59, RFC 5280's date for no expiry, and the clock desktop test loads the routed site 80 years on too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-5480-hb19-routed-sites-certificates-valid
branch
November 13, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
A computer reaches the run's websites by their names (site routing) with certificates from a CA made for the deploy. Those certificates were valid from real now − 5 min to the deploy's ttl + 1 day. Since #649, a computer's session reads the universe's time. So with the clock armed in the past, or more than a day ahead, Chrome refused every routed site with
ERR_CERT_DATE_INVALID.cryptographysigns), to 9999-12-31 23:59:59, RFC 5280's date for no expiry (UNIVERSE_FROM,UNIVERSE_UNTILinsites.py). They hold at any date the gateway's clock takes, so nothing is re-issued when the clock is armed or moved. (The design said 1971–2099; review found the gateway's clock takes dates past 2099.)sites.issueandsites.routeno longer take it, and the deploy record no longer keepssites.valid_for_s. An older record that has it still loads; the field is ignored.Testing
clock_desktop_test.py::test_a_fresh_chrome_loads_a_routed_site_six_years_either_side_of_now_and_past_2099(new)shop.test. With its clock 6 years back, 6 years on and 80 years on, a fresh headless Chrome in the session loadshttps://shop.test/landed, making a TLS handshake of its own each time.net::ERR_CERT_DATE_INVALID, so the test catches the bug.curl and Python don't test the window: they use the system's OpenSSL, whose certificate checks the TLS shim (#639) keeps on real time. Chrome uses its own TLS and checks against the universe's time.
Docs
The site routing page should say that the deploy's CA and site certificates are valid from 1950 to the end of 9999, so they hold whatever the computer's clock shows.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no new blocking issues were found.Summary
The PR gives routed sites’ certificates a fixed lifetime and removes the routing lifetime tied to deployment expiry.
Reviews (5) · Last reviewed commit: "fix(computers): routed sites' certificat..." · Reviewed by Greptile