Repository navigation
CLDSRV-1065: GetNotificationDestination API - #6366
Open
anurag4DSB wants to merge 2 commits into
Open
anurag4DSB wants to merge 2 commits into
anurag4DSB wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## improvement/CLDSRV-1064-destination-create #6366 +/- ##
==============================================================================
+ Coverage 88.18% 88.19% +0.01%
==============================================================================
Files 212 214 +2
Lines 14597 14638 +41
==============================================================================
+ Hits 12872 12910 +38
- Misses 1725 1728 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 10, 2026 13:56
1548713 to
bdd3517
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 10, 2026 15:06
4bc793b to
eb5be89
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 10, 2026 15:06
bdd3517 to
16111a8
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 10, 2026 15:22
eb5be89 to
6c7f664
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 10, 2026 15:23
16111a8 to
fd93c65
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 12, 2026 09:52
6c7f664 to
0a72701
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 09:52
fd93c65 to
8503531
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 12, 2026 09:53
0a72701 to
04182af
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 09:53
8503531 to
8f59a89
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 12, 2026 12:21
04182af to
19e1e34
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 12:21
8f59a89 to
be8e241
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 12, 2026 13:05
19e1e34 to
99d8b2a
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 13:06
be8e241 to
713425b
Compare
anurag4DSB
marked this pull request as ready for review
November 12, 2026 13:38
anurag4DSB
marked this pull request as draft
November 12, 2026 14:21
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 12, 2026 14:40
99d8b2a to
f13a1e8
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 14:40
713425b to
a7b2f42
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 12, 2026 15:02
f13a1e8 to
a9b8de7
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 15:03
a7b2f42 to
b604e88
Compare
anurag4DSB
marked this pull request as ready for review
November 12, 2026 15:18
Add unit tests for the XML element of a destination record. They check: - every field, in order - brokers in stored order - every value escaped - Auth reduced to its Type, for each auth type - no secret string in the output Add unit tests for the Get handler on the in-memory backend, with records that Create stores. They check: - found, unknown and other account 404 - invalid name with no read - store and record errors - no record value in the logs Add functional tests through Create. They check: - every field, and no password, client key or key password in the body - brokers in order - CreatedAt and UpdatedAt in ISO 8601 UTC, to the millisecond - 404, 400 and anonymous 403 - an IAM user allowed on one destination ARN reads that one only Each IAM test makes its own IAM user and destinations, with names that no other test uses, and removes the user when it ends.
- notificationDestinationGet checks the name and reads the record of the requester's account. It answers the NotificationDestination XML, with Auth reduced to its Type. - apiUtils/notificationDestination/xml.js builds the element, so that List reuses it for each entry. - The handler reports its call to the Prometheus metrics, as the bucket APIs do.
anurag4DSB
force-pushed
the
improvement/CLDSRV-1064-destination-create
branch
from
November 12, 2026 15:57
a9b8de7 to
aa1abf8
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 15:57
b604e88 to
b78b066
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: https://claude.ai/artifact/QhKsCqtGNzaVice35nvip9#bcc30d01-27db.m1yth80jczv.20396
Intent: why does this change exist?
System impact: what's affected, including downstream?
Preserved behavior: what explicitly stays the same?
Authholds only itsType.Intended change: what's different after this PR?
Verification: how do we know this worked, or how would we know if it didn't?
mem.s3c-ft-testsandfile-ft-testsread records through Create.https://claude.ai/code/session_01LSEjuApZSsJxDp6dw1FhVa