Repository navigation
CLDSRV-1068: DeleteNotificationDestination API - #6369
Open
anurag4DSB wants to merge 2 commits into
Open
anurag4DSB wants to merge 2 commits into
anurag4DSB wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 3 files with indirect coverage changes @@ Coverage Diff @@
## improvement/CLDSRV-1067-destination-update #6369 +/- ##
==============================================================================
- Coverage 88.33% 88.32% -0.02%
==============================================================================
Files 216 217 +1
Lines 14737 14769 +32
==============================================================================
+ Hits 13018 13044 +26
- Misses 1719 1725 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 10, 2026 14:37
8ce9174 to
e89e403
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 10, 2026 14:37
075fabd to
8098352
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 10, 2026 15:06
e89e403 to
cd38b93
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 10, 2026 15:06
8098352 to
dd119c9
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 10, 2026 15:26
cd38b93 to
bdef8c0
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 10, 2026 15:28
dd119c9 to
2131eea
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 09:52
bdef8c0 to
b3f97de
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 12, 2026 09:52
2131eea to
d6975c3
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 09:53
b3f97de to
24bbad3
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 12, 2026 09:53
d6975c3 to
cc238a5
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 12:21
24bbad3 to
47625a9
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 12, 2026 12:21
cc238a5 to
ecda782
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 13:06
47625a9 to
4c9d0b3
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 12, 2026 13:06
ecda782 to
44a749a
Compare
anurag4DSB
marked this pull request as ready for review
November 12, 2026 13:41
anurag4DSB
marked this pull request as draft
November 12, 2026 14:21
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 14:40
4c9d0b3 to
6509d82
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 12, 2026 14:40
44a749a to
efec70c
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 15:03
6509d82 to
8a14aef
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 12, 2026 15:03
efec70c to
fecf01e
Compare
anurag4DSB
marked this pull request as ready for review
November 12, 2026 15:19
Add unit tests for the Delete handler on the in-memory backend, on a stored record. They check: - the record removed with no body, and Get then answering NoSuchDestination - only the named record removed - an IAM user deleting for its account - an unknown name, a second Delete and another account's name: 404 with no delete call, and the record kept - a record gone between the read and the delete - invalid names: 400 before any read - store read and delete errors, returned unchanged - no record value in the logs Add functional tests through Create, Get and List. They check: - Delete 204 with no body, then Get 404 - an unknown name and a second Delete: 404 - the name created again after a Delete - List no longer showing a deleted name - a bad name 400 - anonymous 403, with the record kept - with a real Vault: an IAM user with no policy gets 403 on Get, List and Delete, with the record kept (Create and Update have blocks of their own) - with a real Vault: a user allowed to delete one destination deletes it and gets 403 on another When each test of the route tests ends, it deletes the destinations that it created, with the credentials of their account. Each IAM test also deletes its IAM user. Thus a run leaves no record. The per-run name suffix stays, for runs that share a server. The api tests no longer say that the destination handlers do not exist yet, and drop the case of a destination method with no handler.
notificationDestinationDelete: - checks the name - reads the record of the requester's account. NoSuchDestination stops the delete. - deletes the record - answers with no body, which the router sends as 204 - logs the name and the account only - reports its call to the Prometheus metrics, as the bucket APIs do Another request can remove the record between the read and the delete. On mem and bucketd, the backend reports the missing key, so the answer is NoSuchDestination. On file, the delete of a missing key succeeds, so the answer is 204. The end state is the same. All five destination handlers now exist. Thus callApiHandler no longer answers NotImplemented to a destination method with no handler.
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 15:58
8a14aef to
40e765b
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1068-destination-delete
branch
from
November 12, 2026 15:58
fecf01e to
ebc0ad7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: https://claude.ai/artifact/QhKsCqtGNzaVice35nvip9#bcc30d01-27db.m1yth80jczv.20396
Intent: why does this change exist?
System impact: what's affected, including downstream?
Preserved behavior: what explicitly stays the same?
file, a record removed by a parallel request still gets 204. The end state is the same.Intended change: what's different after this PR?
afterEach, so a run leaves no record.Verification: how do we know this worked, or how would we know if it didn't?
mem.s3c-ft-testsandfile-ft-testscheck Delete through Get and List.https://claude.ai/code/session_01LSEjuApZSsJxDp6dw1FhVa