Skip to content

CLDSRV-1035: Apply the configured KMIP cluster retries - #6374

Open
dvasilas wants to merge 2 commits into
development/9.2from
bugfix/CLDSRV-1035-apply-configured-kmip-cluster-retries
Open

dvasilas wants to merge 2 commits into
development/9.2from
bugfix/CLDSRV-1035-apply-configured-kmip-cluster-retries

Conversation

@dvasilas

Copy link
Copy Markdown
Contributor

For a KMIP KMS with several hosts, cloudserver ignored the configured number of retries: a non-zero value gave no retry, and 0 gave a retry on every other host.

It now uses the configured value.

@bert-e

bert-e commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-1035 contains:

  • 9.2.44

  • 9.3.26

  • 9.4.11

  • 9.5.3

  • 9.6.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.2.44

  • 9.3.31

  • 9.4.16

  • 9.5.6

  • 9.6.0

Please check the Fix Version/s of CLDSRV-1035, or the target
branch of this pull request.

Comment thread lib/Config.js Resolved
The value was checked but never assigned: a non-zero value gave no retry, and 0 gave a retry on every other host.
@dvasilas
dvasilas force-pushed the bugfix/CLDSRV-1035-apply-configured-kmip-cluster-retries branch from 527a236 to 17373d3 Compare November 13, 2026 14:39
@bert-e

bert-e commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.03%. Comparing base (267e222) to head (17373d3).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/Config.js 81.94% <100.00%> (+1.90%) ⬆️

... and 3 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6374      +/-   ##
===================================================
+ Coverage            84.98%   85.03%   +0.04%     
===================================================
  Files                  205      205              
  Lines                13241    13242       +1     
===================================================
+ Hits                 11253    11260       +7     
+ Misses                1988     1982       -6     
Flag Coverage Δ
file-ft-tests 68.07% <0.00%> (-0.06%) ⬇️
file-ft-tests-null-compat 68.58% <0.00%> (-0.06%) ⬇️
kmip-ft-tests 28.40% <0.00%> (-0.01%) ⬇️
mongo-v0-ft-tests 69.27% <0.00%> (-0.03%) ⬇️
mongo-v1-ft-tests 69.29% <0.00%> (-0.08%) ⬇️
multiple-backend 35.75% <0.00%> (-0.01%) ⬇️
s3c-ft-tests-v0 63.51% <0.00%> (-0.03%) ⬇️
s3c-ft-tests-v0-null-compat 63.57% <0.00%> (-0.01%) ⬇️
s3c-ft-tests-v1 63.46% <0.00%> (-0.01%) ⬇️
sur-tests 36.76% <0.00%> (+0.79%) ⬆️
sur-tests-inflights 37.77% <0.00%> (-0.04%) ⬇️
unit 70.85% <100.00%> (+0.13%) ⬆️
utapi-v2-tests 34.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants