Repository navigation
Enable chunck sizes based on rows (max 1MB by default). - #119
Merged
Merged
Conversation
Member
Author
|
Did some checks on larger chunk sizes for uncompressed data, but didn't see any clear benefits of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ottarph raised this issue. Now chunking is set so it contains full rows. Then a read touches at max 2 extra chunks in paralllel, which is not bad. Increases read performance in serial by a factor of four compared to standard chunking on a 120 K dataset.