Skip to content

Read TARGET and a boolean renew in debug mode - #87

Open
cicnavi wants to merge 1 commit into
masterfrom
fix/debug-mode-target
Open

cicnavi wants to merge 1 commit into
masterfrom
fix/debug-mode-target

Conversation

@cicnavi

@cicnavi cicnavi commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

handleDebugMode() validated the ticket it had just issued against the service from a lowercase 'target' parameter, which no client sends: login() and the validation endpoints read 'TARGET'. With only TARGET given, debug mode therefore answered "Missing service parameter". It also passed the 'renew' query string straight to validate(), which takes a bool, so renew=true failed with a TypeError under strict types.

Read 'TARGET', convert 'renew' with FILTER_VALIDATE_BOOL, and test debug mode with service and with TARGET, each with and without renew.

Assisted-by: Claude Code (claude-opus-5-5, implementation & unit tests)
Assisted-by: Google Antigravity (gemini-3.8-flash-high, review)

handleDebugMode() validated the ticket it had just issued against the
service from a lowercase 'target' parameter, which no client sends:
login() and the validation endpoints read 'TARGET'. With only TARGET
given, debug mode therefore answered "Missing service parameter". It
also passed the 'renew' query string straight to validate(), which
takes a bool, so renew=true failed with a TypeError under strict types.

Read 'TARGET', convert 'renew' with FILTER_VALIDATE_BOOL, and test debug
mode with service and with TARGET, each with and without renew.

Assisted-by: Claude Code (claude-opus-5-5, implementation & unit tests)
Assisted-by: Google Antigravity (gemini-3.8-flash-high, review)
@cicnavi
cicnavi requested a review from ioigoume November 11, 2026 15:09
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.42%. Comparing base (618b649) to head (0359885).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     69.70%   71.42%   +1.72%     
  Complexity      394      394              
============================================
  Files            25       25              
  Lines          1274     1274              
============================================
+ Hits            888      910      +22     
+ Misses          386      364      -22     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant