Repository navigation
fix(sandbox): keep a workbench timeout report when its stop settles after the call deadline - #9619
Closed
waleedlatif1 wants to merge 1 commit into
Closed
waleedlatif1 wants to merge 1 commit into
waleedlatif1 wants to merge 1 commit into
Conversation
…fter the call deadline A workbench run stopped by its own timeout reports its output and files, but both run paths checked the call signal before the report. When the provider's stop round trip outlasted the report reserve, the call deadline had already passed and the run returned a bare timeout with its output dropped. - The cancellation check moves into throwIfRunTimedOut: a passed deadline keeps the report, a cancellation at any point stays a cancellation - One-shot sandboxes and runs that did not time out keep their checks
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge. SummaryKeeps a workbench run’s printed output when its timeout stop finishes after the call deadline.
Reviews (1) · Last reviewed commit: "fix(sandbox): keep a workbench timeout r..." · Reviewed by Greptile |
Collaborator
Author
|
Superseded by #9617, which landed the same change on staging first (the cancellation check moved into |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throwIfRunTimedOut: a deadline that passes while the stop settles keeps the report, and a cancellation at any point stays a cancellationType of Change
Testing
session-sandbox.test.tscase: a 10s workbench run whose stop settles 3s after its own timeout. Red on current staging (bareAbortError: timeout), green with the fixlib/execution/remote-sandbox/suite: 22 files, 592 tests pass, including the existing cancellation-while-listing casecheck:auditsand the full suite are left to CIChecklist
test-auditauthoring gate)