Repository navigation
fix(fx): keep a tool result that shares a user message with text - #103
Open
JaynouOliver wants to merge 1 commit into
Open
JaynouOliver wants to merge 1 commit into
JaynouOliver wants to merge 1 commit into
Conversation
The fx writer took a user message holding both a tool result and text for the next turn's prompt and read only its text, so the call was written with no result. The turn that made the call now takes the results from that message; its text still opens the next turn.
JaynouOliver
marked this pull request as ready for review
November 14, 2026 23:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #102
What changed and why?
Converting a session to fx dropped a tool result when the user message carrying it also had text. The call was written with
tool_results: []and the text became the next prompt.Now the turn that made the call also takes the results from that message; its text still opens the next turn.
Tested with
cargo test -p txcript --test regression fx_: fails without the fix, passes with it.One behaviour change: an aborted call answered by such a message is written as a committed turn with its result, not as
interrupted.I don't have fx installed, so I checked what txcript writes and reads back, not a resume in fx.