Repository navigation
fix(methods): drop default arguments and socket mode from slackbot.skills method examples - #128
Merged
Merged
Conversation
…ot.skills examples Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
….list example Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…ills-examples-docs-values # Conflicts: # methods/README.md
….list example Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…ther examples Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
changed the title
zimeg
marked this pull request as ready for review
November 14, 2026 00:03
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Member
Author
|
🌟 Thanks for the kind review and merge @mwbrooks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request matches the merged
slackbot.skillsandadmin.slackbot.skillsmethod examples to their docs.slack.dev reference pages and the sibling examples.admin.slackbot.skills.listexample:limit,publish_status,auto_enabled_status,sort, andsort_dir.socket_mode_enabledtofalsein theslackbot/skills,slackbot/skills/library, andadmin/slackbot/skillsmanifests, matching the other method example manifests.slackbot/skillsandslackbot/skills/librarymanifests, since everyslackbot.skills.*method accepts a bot token. Theadmin/slackbot/skillsmanifest keeps its user scopes.Follows #113–#123, which merged before these fixes; #124–#126 landed with the same changes in place.
Testing
methods/src/main/java/admin/slackbot/skills/manifest.jsonon an org with Slackbot skills, then runmvn compile exec:java -Dexec.mainClass=admin.slackbot.skills.AdminSlackbotSkillsListwith aSLACK_TOKENand confirm the response lists the org's skills.🤖 Generated with Claude Code