Repository navigation
Ignore JWKs with unsupported key types when parsing JWT bundles - #513
Conversation
|
@cvas22, could you rebase and resolve the conflicts? |
The bundle spec says a JWK with a key type the client doesn't understand must be ignored, but JwtBundle rejected the whole bundle as soon as it saw one (an Ed25519 OKP key, for example). That also made the Workload API client drop the JWT bundle for that trust domain. Skip keys that aren't EC or RSA and keep the rest. Update the tests that relied on the old rejection and add a fixture with an OKP key next to an EC key. Fixes spiffe#512 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
3c2d410 to
807f9de
Compare
|
Rebased on main, the only conflict was the changelog entry next to #511. thx |
|
Not urgent, but the last release was v0.8.17 in April and a good number of fixes have landed on main since. Would a patch release be possible some time soon? Happy to help with anything that's needed for it. thx |
Thanks for the nudge and the offer to help! I’m thinking the next release will be a minor version, and I’m aiming for late November. Do you have any more PRs lined up that you’d like to get in before then? |
Fixes #512
JwtBundle now skips any JWK that isn't EC or RSA instead of failing the whole bundle, so a trust domain that publishes an Ed25519 key next to its EC keys still works over the Workload API. I updated the tests that asserted the old rejection, added a fixture with an OKP and an EC key to check the EC one is kept, and added a changelog entry.