Repository navigation
Conversation
Fyusel
force-pushed
the
git-acl-adjustements
branch
2 times, most recently
from
November 4, 2026 11:48
04e6973 to
d98e51a
Compare
GokceGK
reviewed
Nov 4, 2026
| } | ||
| } | ||
|
|
||
| return outputResult(params.Printer, model.OutputFormat, model.Async, instanceLabel, resp) |
Contributor
There was a problem hiding this comment.
nitpick: we can pass model, and read the required fields in outputResult function.
GokceGK
reviewed
Nov 4, 2026
GokceGK
reviewed
Nov 4, 2026
GokceGK
reviewed
Nov 4, 2026
GokceGK
reviewed
Nov 4, 2026
| } | ||
|
|
||
| func outputResult(p *print.Printer, outputFormat string, async bool, instanceLabel string, resp *git.Instance) error { | ||
| if resp == nil { |
Contributor
There was a problem hiding this comment.
We can move this nil check into the OutputResult lambda function below to fix this output for JSON/YAML
Contributor
|
Not part of this PR, but just recognized while testing. The prompt messages that are used to inform/ confirm, contain text 'stackit git'. I think we should change these to the correct spelling "STACKIT Git." e.g |
Extend describe command to show ACLs. STACKITCLI-555 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Fyusel
force-pushed
the
git-acl-adjustements
branch
from
November 5, 2026 07:01
56f01dd to
0cb9522
Compare
Merging this branch will increase overall coverage
Coverage detailsCompared to commit bc4b561 (run #41845018522)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend describe command to show ACLs.
STACKITCLI-555
Description
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)