Repository navigation
fix(ci): handle pipefail in skill config discovery - #1257
Merged
Merged
Conversation
danbarr
force-pushed
the
fix/check-skills-empty-configs
branch
from
November 20, 2026 00:45
f70b543 to
1b389a9
Compare
Two pipefail bugs in the discover-skill-configs step: - The toolhive check piped git diff into grep -q. grep exits on the first match, git diff gets SIGPIPE (141) on large diffs, and pipefail makes the condition false. Toolhive bumps (e.g. #1246) were not selecting all skills. Discard output instead of -q so grep drains the pipe. - When no skills are selected (e.g. a non-toolhive go.mod bump like #1245), grep -v matches nothing and exits 1, failing the step. Tolerate the no-match exit so the step emits []. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
danbarr
force-pushed
the
fix/check-skills-empty-configs
branch
from
November 20, 2026 00:45
1b389a9 to
318a75d
Compare
danbarr
enabled auto-merge (squash)
November 20, 2026 00:46
aponcedeleonch
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two
pipefailbugs in thediscover-skill-configsstep ofcheck-skills.yml.ToolHive bumps don't select any skills. The toolhive check pipes
git diffintogrep -q.grep -qexits on the first match, so on a large diffgit diffgets SIGPIPE (141) andpipefailmakes the condition false. #1246 (toolhive v0.66.0, a 74 KB diff) hit this. Its list came out empty when it should have included every skill. The fix sends grep's output to/dev/nullinstead of using-q, so grep reads all of the input.Empty config list fails the step. When no skills are selected (for example, a non-toolhive
go.modbump like #1245),grep -v '^$'matches nothing and exits 1, which fails the step with no log output. The fix tolerates the no-match exit so the step outputs[], and the downstream jobs already skip on that.build-skills.ymlandbuild-containers.ymluse the same toolhive check but don't enablepipefail, so they aren't affected.Tested by running the fixed discovery script against both PR heads: #1246 now selects all skills, and #1245 selects none and passes.
🤖 Generated with Claude Code