Repository navigation
Conversation
…ts modal - Keyboard commands now have stable string ids, and KeyboardService supports named, prioritized layers of shortcut overrides on top of the defaults, so other sources (e.g. plugins) can add overrides later. - User overrides are stored in a new synced preference (keyboardShortcutOverrides), which KeyboardService reads from the preferences service and re-applies whenever preferences change. - In the keyboard shortcuts modal, clicking a shortcut records a new key combination. While recording, a cancel button and a "None" button (assign no shortcut) are shown. "Reset all to defaults" appears once any shortcut has been changed. Conflicts with other customized shortcuts are flagged. - Navigation keys (arrows, Tab, Escape) and Super formatting shortcuts stay fixed. - Shortcut labels in menus and tooltips update live via a new useKeyboardShortcut hook. - Fixes command handler disposal clearing onKeyDown twice instead of onKeyUp.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows customizing keyboard shortcuts. The shortcuts can be configured through the existing "Keyboard shortcuts" modal. Clicking a shortcut records a new key combination. While recording, a cancel button and a "None" button (assign no shortcut) are shown. "Reset all to defaults" appears once any shortcut has been changed. Conflicts with other customized shortcuts are flagged.