Repository navigation
Optimize tests - #256
Merged
Merged
Optimize tests#256
Conversation
Was only installed transitively via @swup/plugin
daun
previously approved these changes
Nov 9, 2026
Member
|
🍇 |
Member
Author
|
Putting this on hold until swup/cli#68 is merged and released.... |
5.0.5 checks animation styles without timing, so --parallel is no longer flaky
Member
Author
|
Flaky tests are fixed upstream in swup/cli 5.0.5! Ready to finally merge this. That |
daun
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
npm testvalidated 0 pages and always passed. This fixes the validator run and adds browser smoke tests.Changes
@swup/clito 5.0.5:swup validatenow reads the sitemap (61/61 pages validated) and fails if it finds no pages. The existing animation checks are kept.test:serve:--silent _sitemade_sitethe value of--silent, so the test server served the repo root instead of the built sitetests/smoke.spec.mjs, run vianpm run test:e2e, part ofnpm test):swup.config.jstoswup.config.mjsto silence Node'sMODULE_TYPELESS_PACKAGE_JSONwarning@swup/prettier-configas a devDependency (it was only installed via@swup/plugin)Checks
mainbranchnpm run test)