You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug: spending balance update can skip its fee confirmation #1968
A combined channels-and-Spark Lightning payment can update the spending balance without showing its update fee, when balances change while the payment is being prepared.
The confirm screen's check (confirmSparkUpdateQuote) passes without a quote while Spark can pay alone. If Spark's balance then drops (or channel capacity shrinks) before updateSpendingBalanceIfNeeded runs, after the proof, LNURL and metadata awaits, that later check finds an update is needed and passes a null quote to MoveToSparkRepo.updateToSend, which quotes and moves at once, with no ResetConfirm.
Example from review: a 60 000-sat payment with 50 000 sats in channels moved after Spark fell from 70 000 to 20 000 sats, with no fee shown.
Impact: an unseen routing fee on a move into the user's own Spark wallet; it needs a concurrent balance change inside that window.
Fix idea: when an update is needed at send time and no quote was shown, stop and show the new fee (as confirmSparkUpdateQuote does) instead of quoting and moving.
changed the title [-]fix: spending balance update can skip its fee confirmation[/-][+]bug: spending balance update can skip its fee confirmation[/+]on Nov 18, 2026
Fixed in #1967 by b5328f8: at send time the spending balance update is quoted again. When no fee was shown, or the fee rose since, nothing moves and the payment returns to confirm with the new Update fee, so no fee is charged that the user didn't see.
Activity
[-]fix: spending balance update can skip its fee confirmation[/-][+]bug: spending balance update can skip its fee confirmation[/+]ovitrif commentedon Nov 18, 2026
Fixed in #1967 by b5328f8: at send time the spending balance update is quoted again. When no fee was shown, or the fee rose since, nothing moves and the payment returns to confirm with the new Update fee, so no fee is charged that the user didn't see.