Skip to content

bug: spending balance update can skip its fee confirmation #1968

Closed

Description

@ovitrif

A combined channels-and-Spark Lightning payment can update the spending balance without showing its update fee, when balances change while the payment is being prepared.

The confirm screen's check (confirmSparkUpdateQuote) passes without a quote while Spark can pay alone. If Spark's balance then drops (or channel capacity shrinks) before updateSpendingBalanceIfNeeded runs, after the proof, LNURL and metadata awaits, that later check finds an update is needed and passes a null quote to MoveToSparkRepo.updateToSend, which quotes and moves at once, with no ResetConfirm.

Example from review: a 60 000-sat payment with 50 000 sats in channels moved after Spark fell from 70 000 to 20 000 sats, with no fee shown.

Impact: an unseen routing fee on a move into the user's own Spark wallet; it needs a concurrent balance change inside that window.

Fix idea: when an update is needed at send time and no quote was shown, stop and show the new fee (as confirmSparkUpdateQuote does) instead of quoting and moving.

Found in review of #1967: #1967 (comment)

Activity

  1. added this to the 3.3.0 milestone on Nov 18, 2026
  2. changed the title [-]fix: spending balance update can skip its fee confirmation[/-] [+]bug: spending balance update can skip its fee confirmation[/+] on Nov 18, 2026
  3. ovitrif commented on Nov 18, 2026

    @ovitrif
    CollaboratorAuthor

    Fixed in #1967 by b5328f8: at send time the spending balance update is quoted again. When no fee was shown, or the fee rose since, nothing moves and the payment returns to confirm with the new Update fee, so no fee is charged that the user didn't see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions