Repository navigation
docs: subscribe to the topics Bitkit uses in the wake example - #222
Open
coreyphillips wants to merge 1 commit into
Open
coreyphillips wants to merge 1 commit into
coreyphillips wants to merge 1 commit into
Conversation
talosmachina
left a comment
Contributor
There was a problem hiding this comment.
No findings. Updates the wake README example to register for paykit.* and swap.* instead of blocktank.*, and lists swap.claimable beside paykit.sync as a peer topic. Reviewed 0619f1f, light tier.
What I checked, and 1 candidate I ruled out
Read in full: src/modules/wake/README.md
Checked against the code: swap.* is a well-formed <namespace>.* pattern under the topic rule in src/modules/wake/registration.rs, so the example still passes wakePrepareRegistration.
CI: green (wake-tests, paykit-route-tests, manifests, native-recovery-fixture); usdt-tests was still running at review time.
Ruled out
swap.claimableas a peer topic: nothing in this repo defines the topic catalogue, the gateway'swakeListTopicsdoes, so the README line cannot be checked against code here, and it is prose, not behaviour.
Merge confidence: 5/5, a docs change no test applies to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wake README example subscribed to
blocktank.*, which nothing sends now that Blocktank is shutting down. It now usespaykit.*andswap.*like both apps, and listsswap.claimableas a peer topic.Docs only.