Skip to content

docs: subscribe to the topics Bitkit uses in the wake example - #222

Open
coreyphillips wants to merge 1 commit into
masterfrom
docs/wake-readme-topics
Open

coreyphillips wants to merge 1 commit into
masterfrom
docs/wake-readme-topics

Conversation

@coreyphillips

Copy link
Copy Markdown
Collaborator

The wake README example subscribed to blocktank.*, which nothing sends now that Blocktank is shutting down. It now uses paykit.* and swap.* like both apps, and lists swap.claimable as a peer topic.

Docs only.

@talosmachina talosmachina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Updates the wake README example to register for paykit.* and swap.* instead of blocktank.*, and lists swap.claimable beside paykit.sync as a peer topic. Reviewed 0619f1f, light tier.

What I checked, and 1 candidate I ruled out

Read in full: src/modules/wake/README.md
Checked against the code: swap.* is a well-formed <namespace>.* pattern under the topic rule in src/modules/wake/registration.rs, so the example still passes wakePrepareRegistration.
CI: green (wake-tests, paykit-route-tests, manifests, native-recovery-fixture); usdt-tests was still running at review time.

Ruled out

  • swap.claimable as a peer topic: nothing in this repo defines the topic catalogue, the gateway's wakeListTopics does, so the README line cannot be checked against code here, and it is prose, not behaviour.

Merge confidence: 5/5, a docs change no test applies to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants