Skip to content

feat(run-task): fetch secrets listed in RUN_TASK_SECRETS - #1105

Merged
ahal merged 1 commit into
mainfrom
ahal/kommvppkwoou
Nov 12, 2026
Merged

ahal merged 1 commit into
mainfrom
ahal/kommvppkwoou

Conversation

@ahal

@ahal ahal commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

RUN_TASK_SECRETS is a JSON list of secrets for run-task to fetch before checkout. The first type, github-repo-token, requests a GitHub App installation token from Taskcluster's auth service and exports it to an environment variable, GITHUB_TOKEN by default. Tokens are also kept in memory so run-task can authenticate its own GitHub requests.

@ahal ahal self-assigned this Nov 10, 2026
@ahal

ahal commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

This adds the ability to fetch a Github app installation access token in run-task, which will be needed both for cloning private repos, as well as deriving a more accurate merge base from the Github API (follow-up PR coming for this).

As you might guess from the implementation, the intent here is to also support fetching Taskcluster secrets using this mechanism (a feature I've long meant to implement). But I'll tackle that part separately.

@ahal
ahal added this pull request to stack #1107 November 10, 2026 22:33
@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.13%. Comparing base (781b59f) to head (785504a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
+ Coverage   80.00%   80.13%   +0.13%     
==========================================
  Files         134      134              
  Lines       14190    14288      +98     
  Branches     1645     1654       +9     
==========================================
+ Hits        11352    11450      +98     
  Misses       2399     2399              
  Partials      439      439              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RUN_TASK_SECRETS is a JSON list of secrets for run-task to fetch before
checkout. The first type, github-repo-token, requests a GitHub App
installation token from Taskcluster's auth service and exports it to an
environment variable, GITHUB_TOKEN by default. Tokens are also kept in
memory so run-task can authenticate its own GitHub requests.
@ahal
ahal force-pushed the ahal/kommvppkwoou branch from 01cbd8b to 785504a Compare November 12, 2026 16:28
@ahal
ahal marked this pull request as ready for review November 12, 2026 21:41
@ahal
ahal requested a review from a team as a code owner November 12, 2026 21:41
@ahal
ahal requested a review from hneiva November 12, 2026 21:41
@ahal

ahal commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@hneiva hneiva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahal
ahal merged commit 91c2342 into main Nov 12, 2026
31 checks passed
@ahal
ahal deleted the ahal/kommvppkwoou branch November 12, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants