Repository navigation
docs: Bump tested version to 7.1 - #46
Conversation
[Low impact] The changes affect published plugin and compatibility labels only. Fix the upgrade path before merging so the release does not clear saved Secure Mode keys.
|
fbc83fe to
9a5190d
Compare
| Requires PHP: 5.6 | ||
| Tested up to: 6.9 | ||
| Stable tag: 0.9.3 | ||
| Tested up to: 7.1 |
There was a problem hiding this comment.
Tests can check another version
The PR declares WordPress 7.1 support and says tests should be pinned to that version, but the test setup still uses wordpress:latest and runs wp core update. Repeat runs can therefore check a different WordPress version without any repository change. Pin both the image and the setup script to 7.1 so tests consistently check the release named here.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tawkto/readme.txt
Line: 6
Comment:
**Tests can check another version**
The PR declares WordPress 7.1 support and says tests should be pinned to that version, but the test setup still uses `wordpress:latest` and runs `wp core update`. Repeat runs can therefore check a different WordPress version without any repository change. Pin both the image and the setup script to 7.1 so tests consistently check the release named here.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| * Plugin URI: https://www.tawk.to | ||
| * Description: Embeds Tawk.to live chat widget to your site | ||
| * Version: 0.9.3 | ||
| * Version: 0.9.4 |
There was a problem hiding this comment.
Bumping the plugin version makes sites with a saved tawkto-version of 0.9.3 run old upgrades again. TawkToUpgradeManager::start() checks each upgrade against the new version, but not the saved version. This reruns TawkToUpgradeVersion090::upgrade(), which replaces the saved js_api_key with an empty string. Sites that configured Secure Mode lose their key after updating.
Skip upgrades that already ran and save the current plugin version when finished.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tawkto/tawkto.php
Line: 9
Comment:
**Updating clears saved keys**
Bumping the plugin version makes sites with a saved `tawkto-version` of `0.9.3` run old upgrades again. `TawkToUpgradeManager::start()` checks each upgrade against the new version, but not the saved version. This reruns `TawkToUpgradeVersion090::upgrade()`, which replaces the saved `js_api_key` with an empty string. Sites that configured Secure Mode lose their key after updating.
Skip upgrades that already ran and save the current plugin version when finished.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Whats new
Bump the version from 6.9 to 7.1. Run the Full test suite and pin 7.1 wordpress image to test it properly 100% in latest version of wordpress.