Repository navigation
Conversation
…n version The upgrade manager stored each upgrade's version instead of the current plugin version, so tawkto-version stayed at 0.9.0 and the upgrades re-ran on every request. The 0.9.0 upgrade then reset the Javascript API key, breaking Secure Mode for logged-in visitors. - Only run upgrades newer than the stored version and up to the current one - Store the current plugin version once after the upgrades run - Only initialise the security option in the 0.9.0 upgrade if it is missing - Add 0.9.4 changelog entry
 [Medium impact] The changes affect the plugin’s upgrade flow and logged-in visitor recognition. The PR appears safe to merge; adding regression tests is recommended.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+64
to
+71
| foreach ( $this->upgrades as $upgrade_ver => $upgrade ) { | ||
| if ( version_compare( $upgrade_ver, $this->prev_ver ) > 0 && | ||
| version_compare( $upgrade_ver, $this->curr_ver ) <= 0 ) { | ||
| $this->do_upgrade( $upgrade_ver ); | ||
| } | ||
| } | ||
|
|
||
| update_option( $this->version_var_name, $this->curr_ver ); |
There was a problem hiding this comment.
No existing tests exercise TawkToUpgradeManager or either upgrade. Add coverage for an empty stored version, stored 0.9.0 with current 0.9.4, and a second request after upgrading. Assert which upgrades run, that tawkto-version becomes the current version, and that an existing js_api_key survives. Without these checks, repeated upgrades and key resets could return unnoticed.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tawkto/upgrade.manager.php
Line: 64-71
Comment:
**Upgrade fixes lack regression tests**
No existing tests exercise `TawkToUpgradeManager` or either upgrade. Add coverage for an empty stored version, stored `0.9.0` with current `0.9.4`, and a second request after upgrading. Assert which upgrades run, that `tawkto-version` becomes the current version, and that an existing `js_api_key` survives. Without these checks, repeated upgrades and key resets could return unnoticed.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n version
The upgrade manager stored each upgrade's version instead of the current plugin version, so tawkto-version stayed at 0.9.0 and the upgrades re-ran on every request. The 0.9.0 upgrade then reset the Javascript API key, breaking Secure Mode for logged-in visitors.