Repository navigation
Conversation
The bench rig (a test device) resolves its CPU through parts::ALL, whose doc says the rig takes any part, but R14000_500, the Fuel's R14000A, was missing: `cpu = "r14000_500"` was refused as an unknown CPU. It is now listed after R14000_600, so the bare name `r14000` still picks the 600 MHz part. Test: every_part_is_on_the_bench_rig_and_r14000_names_the_600_mhz_part (fails without the entry). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parts: put the fuel's 500 mhz r14000 on the bench rig
The bench rig (a test device) resolves its CPU through parts::ALL, whose
doc says the rig takes any part, but R14000_500, the Fuel's R14000A, was
missing:
cpu = "r14000_500"was refused as an unknown CPU. It is nowlisted after R14000_600, so the bare name
r14000still picks the600 MHz part.
Test: every_part_is_on_the_bench_rig_and_r14000_names_the_600_mhz_part
(fails without the entry).
Tested on macOS arm64 at the tip:
cargo test --workspace --no-fail-fastwith--features jitv2,rex-jit,gputraceand with default features, andcargo build --release -p iris --bins --features lightning,jitv2,gpujit,idle-pause,hostgl. No failures beyond those upstream main shows on the same host (port-forward restarts, wgpu with no adapter,chd_synced_writes_survive_an_exit_that_skips_drop,resident_plane_raw_pointer_faults_in_child_processes).kona::back::tiles::tests::a_tiled_run_is_bit_exact_with_the_inline_onewas skipped: on main it hangs there under load (the producer spins inTiles::submit/retirewhile every worker sleeps) and passes alone.🤖 Generated with Claude Code